Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ports #3975 to serverless #4293

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

dedemorton
Copy link
Contributor

@dedemorton dedemorton commented Sep 24, 2024

Description

Ports #3957 to serverless.

Also adds a missing period.

Documentation sets edited in this PR

Check all that apply.

  • Stateful (docs/en/observability/*)
  • Serverless (docs/en/serverless/*)
  • Integrations Developer Guide (docs/en/integrations/*)
  • None of the above

Related issue

n/a

Checklist

  • Product/Engineering Review
  • Writer Review

Follow-up tasks

Select one.

  • This PR does not need to be ported to another doc set because:
    • The concepts in this PR only apply to one doc set (serverless or stateful)
    • The PR contains edits to both doc sets (serverless and stateful)
    • This PR is a port.
  • This PR needs to be ported to another doc set:
    • Port to stateful docs: <link to PR or tracking issue>
    • Port to serverless docs: <link to PR or tracking issue>

@dedemorton dedemorton added backport-skip Skip notification from the automated backport with mergify needs-writer-review ci:doc-build labels Sep 24, 2024
@dedemorton dedemorton requested a review from a team as a code owner September 24, 2024 12:42
@dedemorton
Copy link
Contributor Author

@bmorelli25 I'm loving the PR template, but there's a missing state: "This PR is a port" (not sure that's the best wording, but saying "The concepts in this PR only apply to one doc set (serverless or stateful)" isn't correct if the PR is a port from one doc set to another.

@elasticdocs
Copy link

elasticdocs commented Sep 24, 2024

🚀 Built elastic-dot-co-docs-preview-docs successfully!

Issues? Visit #next-docs in Slack

@colleenmcginnis
Copy link
Contributor

@dedemorton @bmorelli25 I wonder if we just add a comment that instructs the author to delete the template and just add a comment with a link for ports: "This is a port of #". Then there is a single source of truth for info about the changes -- the initial PR that is being ported.

Copy link
Contributor

@colleenmcginnis colleenmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dedemorton dedemorton merged commit f6e29d1 into elastic:main Oct 8, 2024
17 checks passed
@dedemorton dedemorton deleted the port#3957_to_serverlless branch October 8, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify ci:doc-build needs-writer-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants