SLO roles privileges changed #4300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
|
This pull request does not have a backport label. Could you fix it @eedugon? 🙏
|
mergify
bot
added
the
backport-skip
eedugon
changed the title
|
Thanks @bmorelli25 for your comments and suggestions here! |
alaudazzi
previously approved these changes
Oct 14, 2024
Co-authored-by: Arianna Laudazzi <[email protected]>
Co-authored-by: Arianna Laudazzi <[email protected]>
change see by check Co-authored-by: Arianna Laudazzi <[email protected]>
eedugon
commented
Oct 15, 2024
| @@ -9,7 +9,7 @@ tags: [ 'serverless', 'observability', 'how-to' ] | |||
|
|
|||
| import Roles from '../partials/roles.mdx' | |||
|
|
|||
| <Roles role="Admin" goal="create SLOs" /> | |||
| <Roles role="Editor" goal="create SLOs" /> | |||
There was a problem hiding this comment.
@dominiqueclarke : I have updated the serverless doc as mentioned in #4229
eedugon
added
backport-8.x
mergify bot
pushed a commit
that referenced
this pull request
Oct 16, 2024
* SLO roles privileges changed to match 8.16 release * editor builtin role information added * wording and order of privileges options changed * minor wording changes * serverless required role updated * rephrasing permissions Co-authored-by: Arianna Laudazzi <[email protected]> * removing future tense Co-authored-by: Arianna Laudazzi <[email protected]> * Update docs/en/observability/slo-privileges.asciidoc change see by check Co-authored-by: Arianna Laudazzi <[email protected]> --------- Co-authored-by: Arianna Laudazzi <[email protected]> (cherry picked from commit bb910be) # Conflicts: # docs/en/serverless/slos/create-an-slo.mdx
10 tasks
bmorelli25
pushed a commit
that referenced
this pull request
Oct 18, 2024
* SLO roles privileges changed (#4300) * SLO roles privileges changed to match 8.16 release * editor builtin role information added * wording and order of privileges options changed * minor wording changes * serverless required role updated * rephrasing permissions Co-authored-by: Arianna Laudazzi <[email protected]> * removing future tense Co-authored-by: Arianna Laudazzi <[email protected]> * Update docs/en/observability/slo-privileges.asciidoc change see by check Co-authored-by: Arianna Laudazzi <[email protected]> --------- Co-authored-by: Arianna Laudazzi <[email protected]> (cherry picked from commit bb910be) # Conflicts: # docs/en/serverless/slos/create-an-slo.mdx * Delete docs/en/serverless directory --------- Co-authored-by: Edu González de la Herrán <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As described at #4229 in 8.16 the SLO permissions have changed, and also the builtin
editorrole is an option to grant privileges for SLOs.This PR updates the
slo-privileges.asciidocand its associated images.It also adds a minor change in serverless doc, as the required role to create SLOs is
Editorand notAdmin.Documentation sets edited in this PR
Check all that apply.
docs/en/observability/*)docs/en/serverless/*)docs/en/integrations/*)Related issue
Closes #4229
Checklist
Follow-up tasks
Select one.