Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update threshold-alert.asciidoc #4349

Open
wants to merge 1 commit into
base: 8.15
Choose a base branch
from
Open

Conversation

arturmouraa
Copy link

@arturmouraa arturmouraa commented Oct 4, 2024

Hey, team, I'm sending this pull request because a customer asked about the bars from the preview chart. It was only showing 3 bars instead of 4, as the customer was expecting to see. However, this is hardcoded and will only show the top 3.

Description

Documentation sets edited in this PR

Check all that apply.

  • Stateful (docs/en/observability/*)
  • Serverless (docs/en/serverless/*)
  • Integrations Developer Guide (docs/en/integrations/*)
  • None of the above

Related issue

Closes #

Checklist

  • Product/Engineering Review
  • Writer Review

Follow-up tasks

Select one.

  • This PR does not need to be ported to another doc set because:
    • The concepts in this PR only apply to one doc set (serverless or stateful)
    • The PR contains edits to both doc sets (serverless and stateful)
  • This PR needs to be ported to another doc set:

Hey, team, I'm sending this pull request because a customer asked about the bars from the preview chart. It was only showing 3 bars instead of 4, as the customer was expecting to see.  However, this is hardcoded and will only show the top 3.
@arturmouraa arturmouraa requested a review from a team as a code owner October 4, 2024 13:41
Copy link
Contributor

github-actions bot commented Oct 4, 2024

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

Copy link
Contributor

@alaudazzi alaudazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dedemorton
Copy link
Contributor

@arturmouraa I'm adding backport labels because I'm assuming this restriction applies to later versions. Let me know if it doesn't (or if we need to follow up to be sure).

Also I've selected the option to port this to serverless because I assume this restriction applies there, too. Thanks for your contribution!

@dedemorton dedemorton added backport-main Automated backport with mergify backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify needs-serverless-port labels Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify backport-main Automated backport with mergify needs-serverless-port
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants