Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update metrics and add legacy section #4386

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Update metrics and add legacy section #4386

merged 1 commit into from
Oct 18, 2024

Conversation

dedemorton
Copy link
Contributor

@dedemorton dedemorton commented Oct 17, 2024 •
edited by bmorelli25
Loading

Description

Adds legacy section and updates CPU usage, Network Inbound, and Network Outbound to show new calculations.

Preview links:

Documentation sets edited in this PR

Check all that apply.

  • Stateful (docs/en/observability/*)
  • Serverless (docs/en/serverless/*)
  • Integrations Developer Guide (docs/en/integrations/*)
  • None of the above

Related issue

Closes #4079

Checklist

  • Product/Engineering Review
  • Writer Review

Follow-up tasks

Select one.

  • This PR does not need to be ported to another doc set because:
    • The concepts in this PR only apply to one doc set (serverless or stateful)
    • The PR contains edits to both doc sets (serverless and stateful)
  • This PR needs to be ported to another doc set:
    • Port to stateful docs: <link to PR or tracking issue>
    • Port to serverless docs: <link to PR or tracking issue>

@dedemorton dedemorton added needs-writer-review ci:doc-build backport-8.x Automated backport to the 8.x branch with mergify needs-product-review labels Oct 17, 2024
@dedemorton dedemorton requested a review from a team as a code owner October 17, 2024 02:08
@github-actions GitHub Actions
Copy link
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@elasticdocs
Copy link

elasticdocs commented Oct 17, 2024 •
edited
Loading

🚀 Built elastic-dot-co-docs-preview-docs successfully!

Issues? Visit #next-docs in Slack

@dedemorton
Copy link
Contributor Author

@roshan-elastic Curious to hear if you like the approach I've taken with the legacy metrics. My thought is that it's better to cover them in a separate section so someone skim reading is less likely to read the wrong description/calculation. I tried it the other way (covering the legacy and new metric calculations in the same table) and thought it was more confusing than having a separate section where we explain what legacy means. WDYT?

@dedemorton dedemorton added the backport-8.16 Automated backport with mergify label Oct 17, 2024
@dedemorton dedemorton self-assigned this Oct 17, 2024
roshan-elastic
roshan-elastic approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@roshan-elastic roshan-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nicely done @dedemorton - LGTM!

@roshan-elastic
Copy link
Contributor

@roshan-elastic Curious to hear if you like the approach I've taken with the legacy metrics. My thought is that it's better to cover them in a separate section so someone skim reading is less likely to read the wrong description/calculation. I tried it the other way (covering the legacy and new metric calculations in the same table) and thought it was more confusing than having a separate section where we explain what legacy means. WDYT?

Love what you've done @dedemorton !

bmorelli25
bmorelli25 approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fascinating!

@dedemorton dedemorton merged commit 6c24013 into elastic:main Oct 18, 2024
35 checks passed
@dedemorton dedemorton deleted the issue##4079 branch October 18, 2024 21:36
mergify bot pushed a commit that referenced this pull request Oct 18, 2024
@dedemorton @mergify
Update metrics and add legacy section (#4386)
74f7ea2 
(cherry picked from commit 6c24013)

# Conflicts:
#	docs/en/serverless/infra-monitoring/host-metrics.mdx
@mergify mergify bot mentioned this pull request Oct 18, 2024
Merged
10 tasks
mergify bot pushed a commit that referenced this pull request Oct 18, 2024
@dedemorton @mergify
Update metrics and add legacy section (#4386)
0d17829 
(cherry picked from commit 6c24013)

# Conflicts:
#	docs/en/serverless/infra-monitoring/host-metrics.mdx
@mergify mergify bot mentioned this pull request Oct 18, 2024
Merged
10 tasks
bmorelli25 pushed a commit that referenced this pull request Oct 18, 2024
@mergify @dedemorton @github-actions
[8.x](backport #4386) Update metrics and add legacy section (#4405)
13976ed 
* Update metrics and add legacy section (#4386)

(cherry picked from commit 6c24013)

# Conflicts:
#	docs/en/serverless/infra-monitoring/host-metrics.mdx

* Delete docs/en/serverless directory

---------

Co-authored-by: DeDe Morton <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
bmorelli25 added a commit that referenced this pull request Oct 19, 2024
@mergify @dedemorton
@github-actions @bmorelli25
[8.16](backport #4386) Update metrics and add legacy section (#4406)
bbb9576 
* Update metrics and add legacy section (#4386)

(cherry picked from commit 6c24013)

# Conflicts:
#	docs/en/serverless/infra-monitoring/host-metrics.mdx

* Delete docs/en/serverless directory

* Update host-metrics.asciidoc

---------

Co-authored-by: DeDe Morton <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Brandon Morelli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmorelli25 bmorelli25 bmorelli25 approved these changes

@roshan-elastic roshan-elastic roshan-elastic approved these changes

Assignees

@dedemorton dedemorton

Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify ci:doc-build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Request]: Update CPU and Network metrics in docs
4 participants
@dedemorton @elasticdocs @roshan-elastic @bmorelli25