Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.16](backport #4396) Add disk metrics to list of docker container metrics #4422

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 22, 2024

Description

Adds disk metrics and calculations to the reference topic about container metrics. (Note that the network metrics were already documented but did not include the calculations.)

Preview links:

Stateful: https://observability-docs_bk_4396.docs-preview.app.elstc.co/guide/en/observability/master/container-metrics.html

Serverless: https://observability-docs_bk_4396.docs-preview.app.elstc.co/guide/en/observability/master/container-metrics.html

Documentation sets edited in this PR

Check all that apply.

  • Stateful (docs/en/observability/*)
  • Serverless (docs/en/serverless/*)
  • Integrations Developer Guide (docs/en/integrations/*)
  • None of the above

Related issue

Closes #4203

Checklist

  • Product/Engineering Review
  • Writer Review

Follow-up tasks

Select one.

  • This PR does not need to be ported to another doc set because:
    • The concepts in this PR only apply to one doc set (serverless or stateful)
    • The PR contains edits to both doc sets (serverless and stateful)
  • This PR needs to be ported to another doc set:
    • Port to stateful docs: <link to PR or tracking issue>
    • Port to serverless docs: <link to PR or tracking issue>

This is an automatic backport of pull request #4396 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner October 22, 2024 16:54
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Oct 22, 2024
Copy link
Contributor Author

mergify bot commented Oct 22, 2024

Cherry-pick of 0984f82 has failed:

On branch mergify/bp/8.16/pr-4396
Your branch is up to date with 'origin/8.16'.

You are currently cherry-picking commit 0984f823.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   docs/en/observability/images/metrics-overlay-containers.png
	modified:   docs/en/observability/monitor-infra/container-details-partial.asciidoc
	modified:   docs/en/observability/monitor-infra/container-metrics.asciidoc

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   docs/en/serverless/images/metrics-overlay-containers.png
	deleted by us:   docs/en/serverless/infra-monitoring/container-metrics.mdx
	deleted by us:   docs/en/serverless/transclusion/container-details.mdx

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@dedemorton dedemorton removed the conflicts There is a conflict in the backported pull request label Oct 22, 2024
@dedemorton dedemorton enabled auto-merge (squash) October 22, 2024 22:34
@dedemorton dedemorton merged commit c56683d into 8.16 Oct 22, 2024
4 checks passed
@dedemorton dedemorton deleted the mergify/bp/8.16/pr-4396 branch October 22, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant