Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add package ml jobs #2496

Merged
merged 19 commits into from
Aug 14, 2023
Merged

Add package ml jobs #2496

merged 19 commits into from
Aug 14, 2023

Conversation

susan-shu-c
Copy link
Member

@susan-shu-c susan-shu-c commented Jul 31, 2023 •
edited
Loading

@susan-shu-c susan-shu-c changed the title Add package ml jobs [WIP] Add package ml jobs Jul 31, 2023
@github-actions
Copy link

Documentation preview:

@susan-shu-c susan-shu-c marked this pull request as draft July 31, 2023 14:11
@mergify
Copy link
Contributor

mergify bot commented Jul 31, 2023

This pull request does not have a backport label. Could you fix it @susan-shu-c? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip automated backport with mergify label Jul 31, 2023
@susan-shu-c susan-shu-c marked this pull request as ready for review August 2, 2023 15:16
@susan-shu-c susan-shu-c changed the title [WIP] Add package ml jobs Add package ml jobs Aug 2, 2023
@susan-shu-c susan-shu-c mentioned this pull request Aug 2, 2023
Closed
ajosh0504
ajosh0504 reviewed Aug 2, 2023
View reviewed changes
Copy link

@ajosh0504 ajosh0504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC we also wanted to update this page to call out that we have pre-built ML jobs in Kibana as well as integration packages?

docs/en/stack/ml/anomaly-detection/ootb-ml-jobs-siem.asciidoc Outdated Show resolved Hide resolved
@susan-shu-c
Copy link
Member Author

Heya @ajosh0504 @sodhikirti07 btw the changes to Apoorva's comment above are here (yeah, it's in another repo haha!)

re:

IIRC we also wanted to update this page to call out that we have pre-built ML jobs in Kibana as well as integration packages?

@susan-shu-c susan-shu-c mentioned this pull request Aug 3, 2023
Merged
sodhikirti07
sodhikirti07 approved these changes Aug 8, 2023
View reviewed changes
Copy link

@sodhikirti07 sodhikirti07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM!

szabosteve
szabosteve approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this addition, LGTM! I left a couple of comments about tiny things. Please take or leave them!

docs/en/stack/ml/anomaly-detection/ootb-ml-jobs-siem.asciidoc Outdated Show resolved Hide resolved
docs/en/stack/ml/anomaly-detection/ootb-ml-jobs-siem.asciidoc Outdated Show resolved Hide resolved
docs/en/stack/ml/anomaly-detection/ootb-ml-jobs-siem.asciidoc Outdated Show resolved Hide resolved
docs/en/stack/ml/anomaly-detection/ootb-ml-jobs-siem.asciidoc Outdated Show resolved Hide resolved
docs/en/stack/ml/anomaly-detection/ootb-ml-jobs-siem.asciidoc Outdated Show resolved Hide resolved
docs/en/stack/ml/anomaly-detection/ootb-ml-jobs-siem.asciidoc Outdated Show resolved Hide resolved
docs/en/stack/ml/anomaly-detection/ootb-ml-jobs-siem.asciidoc Outdated Show resolved Hide resolved
docs/en/stack/ml/anomaly-detection/ootb-ml-jobs-siem.asciidoc Outdated Show resolved Hide resolved
docs/en/stack/ml/anomaly-detection/ootb-ml-jobs-siem.asciidoc Outdated Show resolved Hide resolved
docs/en/stack/ml/anomaly-detection/ootb-ml-jobs-siem.asciidoc Outdated Show resolved Hide resolved
susan-shu-c and others added 7 commits August 9, 2023 10:34
@jmikell821 jmikell821 added backport-8.9 Automated backport with mergify and removed backport-skip Skip automated backport with mergify labels Aug 9, 2023
@jmikell821 jmikell821 merged commit 2d89bdd into main Aug 14, 2023
1 check passed
mergify bot pushed a commit that referenced this pull request Aug 14, 2023
@susan-shu-c @mergify
Add package ml jobs (#2496)
5239ffa 
* Add dga and lotl. Todo: datafeeds

* Add ded and lmd draft

* Add lmd descriptions

* Add package descriptions and subsections

* Update introduction

* Add datafeeds

* Fix typo

* Update headers and address review feedback

* Update docs/en/stack/ml/anomaly-detection/ootb-ml-jobs-siem.asciidoc

Co-authored-by: István Zoltán Szabó <[email protected]>

* Update docs/en/stack/ml/anomaly-detection/ootb-ml-jobs-siem.asciidoc

Co-authored-by: István Zoltán Szabó <[email protected]>

* Update docs/en/stack/ml/anomaly-detection/ootb-ml-jobs-siem.asciidoc

Co-authored-by: István Zoltán Szabó <[email protected]>

* Update docs/en/stack/ml/anomaly-detection/ootb-ml-jobs-siem.asciidoc

Co-authored-by: István Zoltán Szabó <[email protected]>

* Update docs/en/stack/ml/anomaly-detection/ootb-ml-jobs-siem.asciidoc

Co-authored-by: István Zoltán Szabó <[email protected]>

* Batch address feedback

* Batch address feedback

---------

Co-authored-by: István Zoltán Szabó <[email protected]>
Co-authored-by: Janeen Mikell Roberts <[email protected]>
(cherry picked from commit 2d89bdd)
@mergify mergify bot mentioned this pull request Aug 14, 2023
Merged
jmikell821 pushed a commit that referenced this pull request Aug 14, 2023
@mergify @susan-shu-c
Add package ml jobs (#2496) (#2520)
da96b50 
* Add dga and lotl. Todo: datafeeds

* Add ded and lmd draft

* Add lmd descriptions

* Add package descriptions and subsections

* Update introduction

* Add datafeeds

* Fix typo

* Update headers and address review feedback

* Update docs/en/stack/ml/anomaly-detection/ootb-ml-jobs-siem.asciidoc

Co-authored-by: István Zoltán Szabó <[email protected]>

* Update docs/en/stack/ml/anomaly-detection/ootb-ml-jobs-siem.asciidoc

Co-authored-by: István Zoltán Szabó <[email protected]>

* Update docs/en/stack/ml/anomaly-detection/ootb-ml-jobs-siem.asciidoc

Co-authored-by: István Zoltán Szabó <[email protected]>

* Update docs/en/stack/ml/anomaly-detection/ootb-ml-jobs-siem.asciidoc

Co-authored-by: István Zoltán Szabó <[email protected]>

* Update docs/en/stack/ml/anomaly-detection/ootb-ml-jobs-siem.asciidoc

Co-authored-by: István Zoltán Szabó <[email protected]>

* Batch address feedback

* Batch address feedback

---------

Co-authored-by: István Zoltán Szabó <[email protected]>
Co-authored-by: Janeen Mikell Roberts <[email protected]>
(cherry picked from commit 2d89bdd)

Co-authored-by: Susan <[email protected]>
@jmikell821 jmikell821 mentioned this pull request Aug 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajosh0504 ajosh0504 ajosh0504 left review comments

@szabosteve szabosteve szabosteve approved these changes

@sodhikirti07 sodhikirti07 sodhikirti07 approved these changes

@jmikell821 jmikell821 Awaiting requested review from jmikell821

@lcawl lcawl Awaiting requested review from lcawl

Assignees
No one assigned
Labels
backport-8.9 Automated backport with mergify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@susan-shu-c @szabosteve @ajosh0504 @sodhikirti07 @jmikell821