Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.9] Install/Upgrade Guide: Remove + redirect breaking changes pages (backport #2495) #2499

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 1, 2023

This is an automatic backport of pull request #2495 done by Mergify.
Cherry-pick of 583fbef has failed:

On branch mergify/bp/8.9/pr-2495
Your branch is up to date with 'origin/8.9'.

You are currently cherry-picking commit 583fbef1.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   docs/en/install-upgrade/redirects.asciidoc

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   docs/en/install-upgrade/breaking.asciidoc

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

Updates the Install/Upgrade Guide's [Breaking changes](https://www.elastic.co/guide/en/elastic-stack/current/elastic-stack-breaking-changes.html) pages to remove `include::[]` statements for breaking changes. Based on [team feedback](https://elastic.slack.com/archives/C0JF80CJZ/p1690577645566499) (internal link — sorry), these `include`s often break and are difficult to maintain.

Related changes:
- Removes child pages that contain `include`s from other books. Replaces the pages with links to the respective doc books.
- Adds redirects for the removed child pages.
- Adds Fleet/Elastic Agent and Enterprise Search to the list.
- Updates the Beats and Logstash links to point to breaking changes pages. Beats and Logstash rarely has breaking changes.

(cherry picked from commit 583fbef)

# Conflicts:
#	docs/en/install-upgrade/breaking.asciidoc
@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Documentation preview:

@jrodewig jrodewig enabled auto-merge (squash) August 1, 2023 19:24
@jrodewig jrodewig merged commit edd5206 into 8.9 Aug 1, 2023
1 check passed
@mergify mergify bot deleted the mergify/bp/8.9/pr-2495 branch August 1, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant