Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to semantic re-ranking in model ref #2823

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Conversation

leemthompo
Copy link
Contributor

@leemthompo leemthompo commented Oct 4, 2024

making sure links are bidirectional with the the semantic reranking docs page

@leemthompo leemthompo added backport-8.15 Automated backport with mergify backport-8.16 Automated backport with mergify labels Oct 4, 2024
@leemthompo leemthompo self-assigned this Oct 4, 2024
@leemthompo leemthompo requested a review from a team as a code owner October 4, 2024 09:45
Copy link

github-actions bot commented Oct 4, 2024

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

davidkyle
davidkyle previously approved these changes Oct 4, 2024
Copy link
Member

@davidkyle davidkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@marciw marciw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was just wandering by and noticed a duplicate word

docs/en/stack/ml/nlp/ml-nlp-model-ref.asciidoc Outdated Show resolved Hide resolved
Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@leemthompo leemthompo enabled auto-merge (squash) October 7, 2024 07:29
@szabosteve szabosteve merged commit cbf7e88 into main Oct 7, 2024
3 checks passed
@szabosteve szabosteve deleted the leemthompo-patch-link branch October 7, 2024 08:12
mergify bot pushed a commit that referenced this pull request Oct 7, 2024
Co-authored-by: István Zoltán Szabó <[email protected]>
Co-authored-by: Marci W <[email protected]>
(cherry picked from commit cbf7e88)
mergify bot pushed a commit that referenced this pull request Oct 7, 2024
Co-authored-by: István Zoltán Szabó <[email protected]>
Co-authored-by: Marci W <[email protected]>
(cherry picked from commit cbf7e88)
szabosteve pushed a commit that referenced this pull request Oct 7, 2024
Co-authored-by: István Zoltán Szabó <[email protected]>
Co-authored-by: Marci W <[email protected]>
(cherry picked from commit cbf7e88)

Co-authored-by: Liam Thompson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.15 Automated backport with mergify backport-8.16 Automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants