Bugfix: Only pass snapshot settings into the update plan if there are changes #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… changes. - This ensures the settings are only put into the update request if there are actual changes in the config - Otherwise the settings are left out of the payload - This solves a bug where every apply would reset the policy back to the default (because putting the default settings in the plan will cause it to reset the policy). - When using the elasticstack provider to manage the policy, we want the ec provider to not touch it.
gigerdo
force-pushed
the
fix-snapshot-policy-reset-but
branch
from
0517893
to
627c5b1
Compare
nick-benoit
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
#854
Motivation and Context
How Has This Been Tested?
Types of Changes
Readiness Checklist