update tfsdk helpers to use *diags #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is actually causing An empty string isn't valid JSON and is causing the jsontypes.Normalized vars_json to add an error diagnostic. |
|
Implemented an upgrade for fleet_integration_policy, Any streams_json or vars_json as empty strings get reassigned as nulls, so the jsontypes.Normalized wont complain anymore. |
kjwardy
pushed a commit
to kjwardy/terraform-provider-elasticstack
that referenced
this pull request
Oct 21, 2024
* update tfsdk helpers to use *diags * cl * all diags params get pointers * all diags params get pointers * amend changelog * impl upgradeV0 for integration policy * cl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned here, the idea behind the utils/tfsdk.go meta parameters is to pass around response.Diagnostics, the key/index, path, etc. Anything added to meta.diags doesn't actually get returned because it is passed by value and not pointer. This never cropped up in the other tests, mostly because the tests pass, but secondly all the usage is inline, so they reference the outer diags, and not meta.diags.