Move electric_phoenix package into monorepo #2300
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plus fix electric client versioning and update to phoenix liveview 1.x
magnetised
force-pushed
the
magnetised/move-electric-phoenix-into-monorepo
branch
from
68dd3b5 to
233e8c9
Compare
thruflo
reviewed
Feb 7, 2025
|
|
||
| defp deps_for_env(:dev) do | ||
| [ | ||
| {:electric, path: "../sync-service/", env: :dev, only: [:dev, :test], override: true}, |
There was a problem hiding this comment.
This "workspace" approach is a bit tricky. Because presumably when :electric_phoenix is included as a dependency by someone's app, that app can be run in :dev mode.
There was a problem hiding this comment.
hey - yeah. i'm in "trail of destruction" mode. just trying stuff out and getting it working. no plans to include this in the final release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plus fix electric client versioning and update to phoenix liveview 1.x