chore: Minor Connection.Manager
and Consumer
cleanup and flake reduction
#2305
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConnectionBackoff
struct, scope is small and it's verbose (@robacourt nits are good we like them)State
struct everywhere - since we have it it makes sense to use itShapeCache
dependency inConsumer
as it already hasShapeStatus
availableConsumer.whereis
in theConsumer
tests for allowing Mox assertions for consistencyConsumer
test flakes by waiting for theset_snapshot_started
in the setup before running the tests, as the tests "override" some Mox expectations and allowances set in the setup if the snapshot is not ready before they get defined.One thing that really worked for me that I hadn't tried before, is to use a tool like
stress
(e.g.stress -c 10
) to max out the resources used by my machine while running tests to simulate a lower resource system that the tests on CI run on. I managed to consistently reproduce the consumer test flakes that way and debug them.No changeset cause this is all refactoring and test fixing