Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): use new TimeAverageToggle #7118

Merged
merged 6 commits into from
Sep 10, 2024
Merged

Conversation

VIKTORVAV99
Copy link
Member

Issue

Part of: AVO-357

Description

Uses the new TimeAverage toggle of #6911 to make the PR easier to review and reduce the scope of the other PR.

It also removes the last icon we used from FontAwesome as the icon is no longer in the design.

Preview

image

Double check

  • I have run pnpx prettier@2 --write . and poetry run format in the top level directory to format my changes.

@Alportan
Copy link
Contributor

Alportan commented Aug 28, 2024

Looks good from a design perspective ✅ Hurray 🎉

One question, when I switch between the toggle items, I see a "Data is temporary unavailable" message. Is that because of dev environment? I tried a gif, was hard to see due to it's frame rate, but I added a screenshot instead 😅

Screen Cast 2024-08-28 at 3 06 47 PM

@VIKTORVAV99
Copy link
Member Author

Looks good from a design perspective ✅ Hurray 🎉

One question, when I switch between the toggle items, I see a "Data is temporary unavailable" message. Is that because of dev environment? I tried a gif, was hard to see due to it's frame rate, but I added a screenshot instead 😅

Screen Cast 2024-08-28 at 3 06 47 PM

Not because of the dev environment but we have a nasty bug somewhere in the time control logic where a useEffect hook is triggering rendering twice that is proving hard to fix without breaking other stuff.

This is why I added the suspense query before as it should in theory at least hide the issue but that made the whole time controller flash instead which was also sub optimal. What I think I'm gonna try next is creating a simple skeleton like we talked about or some form of hybrid so only parts of the controller are affected.

@VIKTORVAV99 VIKTORVAV99 requested review from madsnedergaard and removed request for a team August 28, 2024 14:40
Copy link
Member

@madsnedergaard madsnedergaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥳

@VIKTORVAV99 VIKTORVAV99 enabled auto-merge (squash) September 10, 2024 13:29
@VIKTORVAV99 VIKTORVAV99 merged commit ce0a5ad into master Sep 10, 2024
22 checks passed
@VIKTORVAV99 VIKTORVAV99 deleted the vik/new_time_average_toggle branch September 10, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants