-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(app): use new TimeAverageToggle #7118
Conversation
Not because of the dev environment but we have a nasty bug somewhere in the time control logic where a useEffect hook is triggering rendering twice that is proving hard to fix without breaking other stuff. This is why I added the suspense query before as it should in theory at least hide the issue but that made the whole time controller flash instead which was also sub optimal. What I think I'm gonna try next is creating a simple skeleton like we talked about or some form of hybrid so only parts of the controller are affected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🥳
Issue
Part of: AVO-357
Description
Uses the new TimeAverage toggle of #6911 to make the PR easier to review and reduce the scope of the other PR.
It also removes the last icon we used from FontAwesome as the icon is no longer in the design.
Preview
Double check
pnpx prettier@2 --write .
andpoetry run format
in the top level directory to format my changes.