Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecation review #144

Merged
merged 3 commits into from
Aug 17, 2023

Conversation

dsanders11
Copy link
Member

Adds a new deprecation review check for PRs.

When requested via the deprecation-review/requested 📝 label, cation will comment on the PR with a checklist of steps for deprecations. Upon all items being checked off or removed by maintainers, cation will change the label to deprecation-review/complete ✅. There's also a GitHub Check so the status can be tracked easily.

This has not been tested end-to-end, but has good test coverage and should be low risk to try out.

@dsanders11 dsanders11 marked this pull request as ready for review August 14, 2023 19:40
@dsanders11 dsanders11 requested review from a team as code owners August 14, 2023 19:40
Copy link

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM - but the logic for fork PRs should be simplified.

src/deprecation-review-state.ts Show resolved Hide resolved
src/deprecation-review-state.ts Outdated Show resolved Hide resolved
src/deprecation-review-state.ts Outdated Show resolved Hide resolved
src/deprecation-review-state.ts Outdated Show resolved Hide resolved
@dsanders11
Copy link
Member Author

dsanders11 commented Aug 14, 2023

Good suggestion @jkleinsc. It's worth noting this is largely copy-paste-modified from src/api-review-state.ts so a similar simplification could be done there.

Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's merge and see what shakes out 😁

@codebytere codebytere merged commit bc6dca1 into electron:main Aug 17, 2023
3 checks passed
@dsanders11 dsanders11 deleted the feat-deprecation-review branch August 17, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants