-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: deprecation review #144
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM - but the logic for fork PRs should be simplified.
Co-authored-by: John Kleinschmidt <[email protected]>
Good suggestion @jkleinsc. It's worth noting this is largely copy-paste-modified from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's merge and see what shakes out 😁
Adds a new deprecation review check for PRs.
When requested via the
deprecation-review/requested 📝
label, cation will comment on the PR with a checklist of steps for deprecations. Upon all items being checked off or removed by maintainers, cation will change the label todeprecation-review/complete ✅
. There's also a GitHub Check so the status can be tracked easily.This has not been tested end-to-end, but has good test coverage and should be low risk to try out.