Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: define practices for third-party extensible APIs #586

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

samuelmaddock
Copy link
Member

A few of Electron's existing APIs don't do a good job of supporting extensibility for third-party libraries. Let's try to define best practices to guide future API designs with third-party extensibility in mind.

protocol.registerSchemesAsPrivileged

session.setPreloads / session.getPreloads

  • Requires replacing all preloads rather than adding a single preload
session.setPreloads([
  ...session.getPreloads(),
  path.join(__dirname, 'new-preload-script.js')
])

@samuelmaddock samuelmaddock requested a review from a team as a code owner October 3, 2024 19:19
wg-api/best-practices.md Outdated Show resolved Hide resolved
wg-api/best-practices.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants