Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify code and clear TODO #1649

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

erikian
Copy link
Member

@erikian erikian commented Jan 3, 2024

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (aa6fd4c) 92.03% compared to head (8d6bdc0) 91.46%.

Files Patch % Lines
src/packager.ts 63.63% 2 Missing and 2 partials ⚠️
src/universal.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1649      +/-   ##
==========================================
- Coverage   92.03%   91.46%   -0.58%     
==========================================
  Files          16       16              
  Lines         854      855       +1     
  Branches      167      167              
==========================================
- Hits          786      782       -4     
- Misses         51       54       +3     
- Partials       17       19       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant