fix: improve speed 15x by using @indutny/breakpad #57
Conversation
indutny
force-pushed
the
feature/speed
branch
4 times, most recently
from
585412a
to
afe1ee6
Compare
| } | ||
|
|
||
| const frames = group.map(({ offset }) => offset); | ||
| const symbolicated = await symbolicateFrames(stream, frames); |
There was a problem hiding this comment.
In case you are wondering, this module streams once through the .sym file without building an index - you have to supply all the offsets that you want to identify right at the call time. Thus we have to group offsets by module first and then symbolicate them module-by-module.
On a good note, this is faster than building an AVL tree, and only an O(N) amount of memory where N is the number of frames.
| const dumpText = await fs.promises.readFile(file, 'utf8') | ||
| const images = binaryImages(dumpText) | ||
| const electronImage = images.find(v => /electron/i.test(v.library)) | ||
| if (electronImage) console.error(`Found Electron ${electronImage.version}`) | ||
| else console.error('No Electron image found') | ||
|
|
||
| let result = [] | ||
| const lines = dumpText.split(/\r?\n/); |
There was a problem hiding this comment.
I've decided to just modify this array in-place instead of rebuilding it from scratch. It is faster, but more importantly I could do a bunch of early continues in the loop and the code is not as deep anymore.
| const image = { | ||
| startAddress: parseInt(startAddress, 16), | ||
| endAddress: parseInt(endAddress, 16), | ||
| plus, | ||
| library, | ||
| version, | ||
| debugId, | ||
| path | ||
| basename: path.basename(modulePath), |
There was a problem hiding this comment.
Just so that we won't have to call them repeatedly all around the place.
indutny
changed the title
Before: ``` $ npm test Test Suites: 2 passed, 2 total Tests: 7 passed, 7 total Snapshots: 4 passed, 4 total Time: 48.887 s ``` After: ``` $ npm test Test Suites: 2 passed, 2 total Tests: 7 passed, 7 total Snapshots: 4 passed, 4 total Time: 3.186 s ```
|
Friendly ping @nornagon ? |
|
🤗 (keeping this up in the inbox!) |
|
Never give up :) |
|
🥹 |
Before:
After:
@indutny/breakpadalso provides file/line number information, but I didn't want to make changes to the output format. Let me know if you want to add them in!cc @nornagon