Feat: Stop Looking for updates #178
Conversation
| @@ -7,6 +7,7 @@ on: | |||
| schedule: | |||
| - cron: '0 22 * * 3' | |||
| workflow_call: | |||
| workflow_dispatch: | |||
There was a problem hiding this comment.
so anyone that forks the repo can run the tests locally in the fork
Could you just have this in your fork and avoid upstreaming it? 🤔
There was a problem hiding this comment.
I needed upstream this to run the tests easier locally here. This grants me the power to run anytime the tests, I only use Linux and my hardware can't run VMs. So the only way I can test it in other platforms is using Github Actions. If you want I can remove it, but only when the other needed changes were done
src/index.ts
Outdated
| // check for bad input early, so it will be logged during development | ||
| const safeOpts = validateInput(opts); | ||
| export async function updateElectronApp(opts: IUpdateElectronAppOptions = {}): Promise<IUpdater> { | ||
| return new Promise((resolve, reject) => { |
There was a problem hiding this comment.
question: what's the intent around this Promise wrapping? From what I see, we're just manually wrapping the sync code in the Promise in this function, and initUpdater is still synchronous.
There was a problem hiding this comment.
I modified the initUpdater to return an updater controller. But when I call updateElectronApp and the app is not ready I can't return this controller because initUpdater is called inside of a callback. So I used resolve from Promise to avoid this problem and return the updater controller
This implements the feature request #65 and adds a manual workflow dispatch, so anyone that forks the repo can run the tests locally in the fork