Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Structures Sidebar Not Alphabetized #526

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

botPuneet
Copy link

fixes issue #408 added a sorting function in create-sidebar.ts to sort the sidebar in api

@botPuneet
Copy link
Author

Hey, @dsanders11 pls review this and guide me for any changes it needed

@erickzhao erickzhao self-assigned this May 14, 2024
@@ -178,6 +178,22 @@ export const createSidebar = async (root: string, destination: string) => {
prettierConfig
);

for (const id of Object.keys(sidebars)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue(blocking): this won't work because the formattedSidebarString is parsed before we do any of the in-place sorting.

I also think we would want to only have this available for the API Structures categories, rather than every single sidebar category recursively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants