Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix React 17/Webpack 4 compatibility #46

Merged
merged 9 commits into from
Aug 1, 2023
Merged

Fix React 17/Webpack 4 compatibility #46

merged 9 commits into from
Aug 1, 2023

Conversation

sandhose
Copy link
Member

@sandhose sandhose commented Aug 1, 2023

  • Move react* to peer dependencies, making it compatible with React 17
  • Stop using React.JSX.Element and explicitly type all components
  • Add react and react-dom to the dev dependencies
  • Upgrade typescript and vite-plugin-dts to fix the output files

@sandhose sandhose requested a review from a team as a code owner August 1, 2023 13:30
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Aug 1, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 320bdaf
Status: ✅  Deploy successful!
Preview URL: https://40381633.compound-web.pages.dev
Branch Preview URL: https://quenting-react-17-compat.compound-web.pages.dev

View logs

germain-gg
germain-gg reviewed Aug 1, 2023
View reviewed changes
vite.config.ts Outdated Show resolved Hide resolved
germain-gg
germain-gg reviewed Aug 1, 2023
View reviewed changes
Copy link
Contributor

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me! As soon as we can get a confirmation with the snapshot test id be happy to go with this!

src/components/ActionControl/__snapshots__/ActionControl.test.tsx.snap Show resolved Hide resolved
@germain-gg
Copy link
Contributor

Thank you very much for your help on this @sandhose ❤️ !

@germain-gg germain-gg merged commit f42628a into main Aug 1, 2023
7 checks passed
@germain-gg germain-gg deleted the quenting/react-17-compat branch August 1, 2023 15:08
@sandhose sandhose mentioned this pull request Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@germain-gg germain-gg germain-gg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sandhose @germain-gg