Bump io.element.android:wysiwyg from 2.14.1 to 2.22.0 #8711
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [io.element.android:wysiwyg](https://github.com/matrix-org/matrix-wysiwyg) from 2.14.1 to 2.22.0. - [Changelog](https://github.com/matrix-org/matrix-rich-text-editor/blob/main/CHANGELOG.md) - [Commits](matrix-org/matrix-rich-text-editor@2.14.1...2.22.0) --- updated-dependencies: - dependency-name: io.element.android:wysiwyg dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
dependencies
dependabot
bot
requested review from
a team and
bmarty
and removed request for
a team
|
This should fix #8712 |
| override fun resolveAtRoomMentionDisplay(): TextDisplay = | ||
| pillDisplayHandler?.resolveAtRoomMentionDisplay() ?: TextDisplay.Plain | ||
| } | ||
| ) |
There was a problem hiding this comment.
mentionDisplayHandler is now private, so using updateStyle with existing styleConfig for the first parameter. There is maybe another way to set mentionDisplayHandler?
There was a problem hiding this comment.
This is the right way to do it now. We did this to minimize the number of times we need to re-create the underlying HtmlToSpanConverter, specially in Compose.
| styleConfig = it.styleConfig, | ||
| mentionDisplayHandler = null, | ||
| ) | ||
| } |
There was a problem hiding this comment.
@jmartinesp let me know what you think about this fix.
There was a problem hiding this comment.
This is a bit weird, updateStyle should automatically be called when it's attached to a window. Are we settings the text in this component before that happens? If so, then yes, we need to add this workaround.
There was a problem hiding this comment.
Yes, this seems to be the case. It's alright then. Maybe in the next RTE version we can change it so it's done as soon as it's instantiated.
There was a problem hiding this comment.
I have put a breakpoint in EditorStyledTextView.onAttachedToWindow() but was not reaching it before the app crashes.
bmarty
deleted the
dependabot/gradle/io.element.android-wysiwyg-2.22.0
branch
Bumps io.element.android:wysiwyg from 2.14.1 to 2.22.0.
Changelog
Sourced from io.element.android:wysiwyg's changelog.
... (truncated)
Commits
fcfef8aVersion 2.22.0 (#909)d43db0a[Rust] fix multiple lines in markdown mode (#907)efe567d[iOS] Key Commands Refactor (#908)91fae40Fix enter right after mention crashing the editor (#904)a87e5e6[Android] ImplementreplaceText(#902)3529e0dMerge pull request #901 from matrix-org/version-2.21.03372341Add entry in CHANGELOG.mdc14a63eRunmake web61d3f59Prepare release 2.21.01dbba97Merge pull request #899 from matrix-org/jme/android-fix-paparazzi-testsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)