Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 'sign in' flow more important in the initial screen #8741

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Make 'sign in' flow more important in the initial screen #8741

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/+update-login-splash-screen.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Switch the position and styles of the 'already have an account' and 'create account' buttons in the login splash screen. Also changes the 'already have an account one' to just say 'sign in'.
1 change: 1 addition & 0 deletions library/ui-strings/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2095,6 +2095,7 @@
<string name="login_splash_text2">Keep conversations private with encryption</string>
<string name="login_splash_text3">Extend &amp; customize your experience</string>
<string name="login_splash_submit">Get started</string>
<string name="login_splash_sign_in">Sign In</string>
<string name="login_splash_create_account">Create account</string>
<string name="login_splash_already_have_account">I already have an account</string>

Expand Down
14 changes: 7 additions & 7 deletions vector/src/main/res/layout/fragment_ftue_splash_carousel.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,30 +57,30 @@
app:layout_constraintTop_toBottomOf="@id/carouselIndicator" />

<Button
android:id="@+id/loginSplashSubmit"
android:id="@+id/loginSplashAlreadyHaveAccount"
style="@style/Widget.Vector.Button.Login"
android:layout_width="0dp"
android:layout_height="wrap_content"
android:text="@string/login_splash_sign_in"
android:textAllCaps="true"
android:transitionName="loginSubmitTransition"
app:layout_constraintBottom_toTopOf="@id/loginSplashAlreadyHaveAccount"
app:layout_constraintBottom_toTopOf="@id/loginSplashSubmit"
app:layout_constraintEnd_toEndOf="@id/splashCarouselGutterEnd"
app:layout_constraintStart_toStartOf="@id/splashCarouselGutterStart"
app:layout_constraintTop_toBottomOf="@id/loginSplashButtonsSpace"
tools:text="@string/login_splash_create_account" />
app:layout_constraintTop_toBottomOf="@id/loginSplashButtonsSpace" />

<Button
android:id="@+id/loginSplashAlreadyHaveAccount"
android:id="@+id/loginSplashSubmit"
style="@style/Widget.Vector.Button.Text.Login"
android:layout_width="0dp"
android:layout_height="wrap_content"
android:text="@string/login_splash_already_have_account"
android:textAllCaps="true"
android:transitionName="loginSubmitTransition"
app:layout_constraintBottom_toTopOf="@id/loginSplashBottomSpace"
app:layout_constraintEnd_toEndOf="@id/splashCarouselGutterEnd"
app:layout_constraintStart_toStartOf="@id/splashCarouselGutterStart"
app:layout_constraintTop_toBottomOf="@id/loginSplashSubmit" />
app:layout_constraintTop_toBottomOf="@id/loginSplashAlreadyHaveAccount"
tools:text="@string/login_splash_create_account" />

<Space
android:id="@+id/loginSplashBottomSpace"
Expand Down
Loading