Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump matrix-js-sdk for MSC4222 support #2759

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

robintown
Copy link
Member

@robintown robintown commented Nov 11, 2024

This bumps matrix-js-sdk to a branch https://github.com/matrix-org/matrix-js-sdk/tree/element-call-nov-preview that includes

in addition to everything we've gotten merged so far into develop. A smoke test indicates that the MSC4222 support appears to be working fine.

@hughns
Copy link
Member

hughns commented Nov 12, 2024

n.b. this would impact the codepaths for EC running as an SPA but also for when it runs as embedded. So, both need testing.

@toger5
Copy link
Contributor

toger5 commented Nov 12, 2024

We do not need any additional changes to element call (embedded + spa)
As we hoped for it all works as it is now.

Context for why this works:

if (this.syncApi instanceof SyncApi)
    // sync V2
    // if the third (`stateAfterEventList`) parameter is undefined, `injectRoomEvents` will use the fourth (`timelineEventList`)
    // parameter with the legacy behaviour (using theimeline events as state events + emitting state changes)
    await this.syncApi.injectRoomEvents(this.room!, [], undefined, [event]);
} else {
    // SSS
    // not used in EC (even though matroska mode supports it) via client `opts.slidingSync`
    await this.syncApi!.injectRoomEvents(this.room!, [], [event]);
}

Copy link
Contributor

@toger5 toger5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in a comment above this just work as it is because the js-sdk supporting MSC4222 will behave as before by default:

  • all timeline events will update the state.
  • The react sdk stop gap driver will only send state_after

So we get the bahaviour we want

@robintown robintown merged commit 6c24763 into element-hq:livekit Nov 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants