Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regressions on the right chat panel with bubble message layout enabled #21774

Closed
2 of 3 tasks
luixxiul opened this issue Apr 13, 2022 · 5 comments
Closed
2 of 3 tasks
Labels
A-Right-Panel O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect X-Regression

Comments

@luixxiul
Copy link

luixxiul commented Apr 13, 2022

Steps to reproduce

  1. Change the message layout to Message bubbles
  2. Create a room
  3. Add a widget to the room
  4. Maximize the widget
  5. Post something to the chat
  6. Reply in thread

Outcome

What did you expect?

  • There should not be overflow of anything.
  • The style rules for the chat and thread right panel should be integrated.

What happened instead?

before1

Operating system

Debian

Browser information

Firefox

URL for webapp

localhost

Application version

develop branch

Homeserver

No response

Will you send logs?

No

@dbkr dbkr added X-Regression S-Tolerable Low/no impact on users A-Right-Panel O-Occasional Affects or can be seen by some users regularly or most users rarely labels Apr 13, 2022
@luixxiul luixxiul changed the title Regressions on the right chat panel Regressions on the right chat panel with bubble message layout enabled Apr 13, 2022
@luixxiul
Copy link
Author

None of those overflow issues are reproduced on the modern message layout- they are specific to the message bubble layout.

@frakic
Copy link

frakic commented Jun 1, 2022

Encountered a similar issue during a Community testing session.

  1. Have message bubbles turned on
  2. Join a video room
  3. Have an iOS/Android user start a conference
  4. Have them end the conference
  5. See the chat window

Expected: no overflows, video conference events display nicely
Actual: read receipts are cut off, conference event bubble is too tight

image

@luixxiul
Copy link
Author

luixxiul commented Jun 1, 2022

@frakic that should be fixed with matrix-org/matrix-react-sdk#8470.

@weeman1337
Copy link
Contributor

Read avatar overflow: fixed with

Is back:

image

@luixxiul
Copy link
Author

luixxiul commented Mar 10, 2023

The issue should no longer be reproduced not only on TimelineCard but also ThreadView with matrix-org/matrix-react-sdk#10335

But it will not fix the issue that the read receipts are not displayed properly on lines inside GELS (generic event list summary).

Screenshot from 2023-03-09 04-59-05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Right-Panel O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users T-Defect X-Regression
Projects
None yet
Development

No branches or pull requests

5 participants