Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Naively) attempt to replace babel & terser with esbuild #26079

Closed
wants to merge 2 commits into from

Conversation

Johennes
Copy link
Contributor

@Johennes Johennes commented Aug 30, 2023

This is a naive and uninformed experiment that replaces babel and terser with esbuild (which, among others, is used by Vite for external dependencies).

On my MacBook a clean yarn build takes ~70s before and ~40s after this change. Some of this gain might be undone or outweighed by the caveats listed below.

Caveats & things to figure out


This change is marked as an internal change (Task), so will not be included in the changelog.

@Johennes Johennes added the T-Task Tasks for the team like planning label Aug 30, 2023
@t3chguy
Copy link
Member

t3chguy commented Aug 31, 2023

esbuild doesn't do any type checking

Neither does babel, it relies on you running tsc yourself.

https://babeljs.io/docs/babel-plugin-transform-typescript

However, this plugin does not add the ability to type-check the JavaScript passed to it. For that, you will need to install and set up TypeScript.

@Johennes
Copy link
Contributor Author

Neither does babel, it relies on you running tsc yourself.

Oh, I see. Thanks, I've struck out that bullet in the description.

@CLAassistant
Copy link

CLAassistant commented Sep 6, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Johennes
Copy link
Contributor Author

Johennes commented Sep 6, 2024

Given the timeline, I fear this probably is a dead end. Assuming there's no interest in following through on this, I'm closing it. Was an interesting experiment either way.

@Johennes Johennes closed this Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants