Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feature_disable_call_per_sender_encryption documentation (in labs.md) #26548

Merged
merged 4 commits into from
Nov 17, 2023
Merged

Add feature_disable_call_per_sender_encryption documentation (in labs.md) #26548

merged 4 commits into from
Nov 17, 2023

Conversation

toger5
Copy link
Contributor

@toger5 toger5 commented Nov 10, 2023 •
edited by github-actions bot
Loading

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Here's what your changelog entry will look like:

✨ Features

  • Add feature_disable_call_per_sender_encryption documentation (in labs.md) (#26548). Contributed by @toger5.

@toger5 toger5 requested a review from a team as a code owner November 10, 2023 14:42
@toger5 toger5 mentioned this pull request Nov 10, 2023
Merged
3 tasks
richvdh
richvdh reviewed Nov 10, 2023
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally looks good but I think the wording could do with clarification

docs/labs.md Outdated Show resolved Hide resolved
@toger5
review
d073bcf 
Signed-off-by: Timo K <[email protected]>
@toger5
prettier
de7f8ef 
Signed-off-by: Timo K <[email protected]>
@toger5 toger5 assigned toger5 and unassigned toger5 Nov 10, 2023
@toger5 toger5 added the T-Other Questions, user support, anything else label Nov 10, 2023
@toger5
Copy link
Contributor Author

toger5 commented Nov 10, 2023

We dont need a changelog here right? It will be listed under the react sdk changes in the next release?

@toger5 toger5 added T-Task Tasks for the team like planning T-Enhancement and removed T-Task Tasks for the team like planning T-Other Questions, user support, anything else labels Nov 10, 2023
@richvdh
Copy link
Member

richvdh commented Nov 10, 2023

yes agreed

aceArt-GmbH
aceArt-GmbH reviewed Nov 13, 2023
View reviewed changes
docs/labs.md Outdated Show resolved Hide resolved
@toger5 @aceArt-GmbH
Update docs/labs.md
5b38971 
Co-authored-by: aceArt-GmbH <[email protected]>
Aziz-4980
Aziz-4980 reviewed Nov 14, 2023
View reviewed changes
Copy link

@Aziz-4980 Aziz-4980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good tp me

@toger5 toger5 requested a review from richvdh November 17, 2023 15:59
richvdh
richvdh approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@toger5 toger5 merged commit 3c3ec88 into develop Nov 17, 2023
21 checks passed
@toger5 toger5 deleted the toger5/add_feature_disable_call_per_sender_encryption_docs branch November 17, 2023 16:38
DarkKirb pushed a commit to DarkKirb/element-web that referenced this pull request Nov 19, 2023
@toger5 @aceArt-GmbH @DarkKirb
Add feature_disable_call_per_sender_encryption documentation (in labs…
2fdec9b 
….md) (element-hq#26548)

* add feature_disable_call_per_sender_encryption doc

Co-authored-by: aceArt-GmbH <[email protected]>

---------

Signed-off-by: Timo K <[email protected]>
Co-authored-by: aceArt-GmbH <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aziz-4980 Aziz-4980 Aziz-4980 left review comments

@aceArt-GmbH aceArt-GmbH aceArt-GmbH left review comments

@richvdh richvdh richvdh approved these changes

@t3chguy t3chguy Awaiting requested review from t3chguy t3chguy is a code owner automatically assigned from element-hq/element-web-reviewers

@MidhunSureshR MidhunSureshR Awaiting requested review from MidhunSureshR MidhunSureshR is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees
No one assigned
Labels
T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@toger5 @richvdh @aceArt-GmbH @Aziz-4980