Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pinned message e2e flakes #28268

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Fix pinned message e2e flakes #28268

merged 1 commit into from
Oct 23, 2024

Conversation

florianduros
Copy link
Member

@florianduros florianduros commented Oct 22, 2024 •
edited
Loading

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

Closes #28149
Closes #27950
Because I make CSS comment with js syntax 🤡

@florianduros florianduros added the T-Task Tasks for the team like planning label Oct 22, 2024
@florianduros florianduros marked this pull request as ready for review October 22, 2024 14:54
@florianduros florianduros requested a review from a team as a code owner October 22, 2024 14:54
@florianduros florianduros added this pull request to the merge queue Oct 23, 2024
Merged via the queue into develop with commit 83777a6 Oct 23, 2024
62 of 63 checks passed
@florianduros florianduros deleted the florianduros/fix-pinned-message-flake branch October 23, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3chguy t3chguy t3chguy approved these changes

@MidhunSureshR MidhunSureshR Awaiting requested review from MidhunSureshR MidhunSureshR is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
2 participants
@florianduros @t3chguy