Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schedule dehydration on reload if the dehydration key is already cached locally #29021

Merged
merged 5 commits into from
Jan 31, 2025
Merged

Schedule dehydration on reload if the dehydration key is already cached locally #29021

merged 5 commits into from
Jan 31, 2025

Conversation

uhoreg
Copy link
Member

@uhoreg uhoreg commented Jan 17, 2025 •
edited
Loading

Depends on matrix-org/matrix-js-sdk#4664

Fixes #29031

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

@uhoreg uhoreg requested a review from a team as a code owner January 17, 2025 23:48
@uhoreg uhoreg requested review from dbkr and t3chguy January 17, 2025 23:48
@uhoreg uhoreg marked this pull request as draft January 17, 2025 23:48
@uhoreg uhoreg force-pushed the schedule_dehydration_on_reload branch from df668b6 to da898e8 Compare January 18, 2025 14:31
@t3chguy t3chguy removed request for dbkr and t3chguy January 20, 2025 09:03
@uhoreg uhoreg changed the title Schedule dehydration on reload Schedule dehydration on reload if the dehydration key is already cached Jan 29, 2025
@uhoreg uhoreg changed the title Schedule dehydration on reload if the dehydration key is already cached Schedule dehydration on reload if the dehydration key is already cached locally Jan 29, 2025
@uhoreg uhoreg marked this pull request as ready for review January 30, 2025 15:50
@uhoreg uhoreg requested a review from a team as a code owner January 30, 2025 15:50
@uhoreg uhoreg requested a review from andybalaam January 30, 2025 15:50
andybalaam
andybalaam approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks.

@uhoreg uhoreg added this pull request to the merge queue Jan 31, 2025
Merged via the queue into element-hq:develop with commit 4cba79d Jan 31, 2025
46 of 47 checks passed
@uhoreg uhoreg deleted the schedule_dehydration_on_reload branch January 31, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andybalaam andybalaam andybalaam approved these changes

Assignees
No one assigned
Labels
T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Device Dehydration | element-web: schedule dehydration if dehydration key is stored
2 participants
@uhoreg @andybalaam