Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/bma/test pin unlock presenter #1870

Closed
wants to merge 5 commits into from

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Nov 23, 2023

Add some preview and test on the presenter

@bmarty bmarty requested a review from ganfra November 23, 2023 15:53
@bmarty bmarty requested a review from a team as a code owner November 23, 2023 15:53
}
}

@Composable
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not recorded by Paparazzi :/

Copy link
Contributor

github-actions bot commented Nov 23, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/iCEGE1

Copy link
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except looks like there is a test not passing?

@bmarty
Copy link
Member Author

bmarty commented Nov 23, 2023

Weird, all is green locally. Second attempt on the CI.

@bmarty bmarty force-pushed the feature/bma/testPinUnlockPresenter branch from b7a7053 to 09323f6 Compare November 28, 2023 10:03
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@bmarty
Copy link
Member Author

bmarty commented Dec 5, 2023

CI is not happy, let's resume this later.

@bmarty bmarty closed this Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants