Upgrade to rust sdk 0.1.71 #1905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julioromano
force-pushed
the
julioromano/bump_sdk
branch
from
c535001 to
32175d7
Compare
julioromano
force-pushed
the
julioromano/bump_sdk
branch
from
32175d7 to
8716b88
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1905 +/- ##
===========================================
- Coverage 66.53% 66.53% -0.01%
===========================================
Files 1309 1309
Lines 33110 33109 -1
Branches 7094 7094
===========================================
- Hits 22031 22028 -3
- Misses 7718 7720 +2
Partials 3361 3361 ☔ View full report in Codecov by Sentry. |
julioromano
added
the
Run-Maestro
github-actions
bot
removed
the
Run-Maestro
This was referenced Nov 28, 2023
Closed
bmarty
approved these changes
Nov 29, 2023
| EnableRecoveryProgress.CreatingBackup, | ||
| EnableRecoveryProgress.CreatingRecoveryKey -> | ||
| Unit | ||
| is EnableRecoveryProgress.RoomKeyUploadError -> Unit |
There was a problem hiding this comment.
I guess this new case RoomKeyUploadError should be handled differently, but I can do it in a separate PR (i.e. not block this one).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/matrix-org/matrix-rust-components-kotlin/releases/tag/sdk-v0.1.71
There are breaking changes as specified in: #1898 plus the one related to the poll history feature.