Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore Github PAT in record screenshots, disable Maestro for forks #2147

Merged
merged 3 commits into from
Jan 3, 2024

Conversation

jmartinesp
Copy link
Member

@jmartinesp jmartinesp commented Jan 2, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other : fix CI (again)

Content

  • Restores the GH PAT so we can use the record screenshot action properly and not have the CI blocked for ourselves.
  • Skips Maestro check for PRs from forks, since it won't be able to run anyway.
  • Adds a new workflow that should run on PRs from forks and add a comment explaining different checks and how to handle the record screenshots task.

Motivation and context

Fix Record screenshots blocking the CI until a new commit is uploaded in our repo.

@jmartinesp jmartinesp added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Jan 2, 2024
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Jan 2, 2024
Copy link
Contributor

github-actions bot commented Jan 2, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/cr58Zu

This is needed to trigger CI jobs automatically. In the case where this is not possible (forks) a message will be added to ask the user to add an empty commit to trigger the CI.
@jmartinesp jmartinesp force-pushed the misc/jme/restore-pat-in-record-screenshots branch from 9055d99 to 805dfe3 Compare January 2, 2024 15:35
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 48 lines in your changes are missing coverage. Please review.

Comparison is base (2134004) 67.05% compared to head (805dfe3) 67.02%.
Report is 1 commits behind head on develop.

Files Patch % Lines
...ctories/event/TimelineItemContentMessageFactory.kt 0.00% 12 Missing and 1 partial ⚠️
...meline/components/event/TimelineItemStickerView.kt 56.25% 2 Missing and 5 partials ⚠️
...ctories/event/TimelineItemContentStickerFactory.kt 63.15% 1 Missing and 6 partials ⚠️
...ndroid/features/messages/impl/MessagesPresenter.kt 0.00% 4 Missing and 1 partial ⚠️
.../messages/impl/timeline/model/InReplyToMetadata.kt 0.00% 4 Missing and 1 partial ⚠️
...e/components/event/TimelineItemEventContentView.kt 0.00% 2 Missing and 1 partial ⚠️
...s/messages/impl/timeline/model/InReplyToDetails.kt 0.00% 2 Missing and 1 partial ⚠️
...eatures/messages/impl/actionlist/ActionListView.kt 0.00% 1 Missing and 1 partial ⚠️
...timeline/model/event/TimelineItemStickerContent.kt 86.66% 1 Missing and 1 partial ⚠️
...tils/messagesummary/MessageSummaryFormatterImpl.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2147      +/-   ##
===========================================
- Coverage    67.05%   67.02%   -0.04%     
===========================================
  Files         1371     1374       +3     
  Lines        34007    34116     +109     
  Branches      7487     7523      +36     
===========================================
+ Hits         22805    22867      +62     
- Misses        7587     7615      +28     
- Partials      3615     3634      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmartinesp jmartinesp requested a review from ganfra January 2, 2024 15:38
@jmartinesp jmartinesp added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jan 2, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jan 2, 2024
@jmartinesp jmartinesp marked this pull request as ready for review January 2, 2024 15:38
@jmartinesp jmartinesp requested a review from a team as a code owner January 2, 2024 15:38
Copy link

sonarqubecloud bot commented Jan 2, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@jmartinesp jmartinesp merged commit 0381027 into develop Jan 3, 2024
16 of 18 checks passed
@jmartinesp jmartinesp deleted the misc/jme/restore-pat-in-record-screenshots branch January 3, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants