Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable forwarding for stickers (until it can be properly fixed) #2162

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

surakin
Copy link
Contributor

@surakin surakin commented Jan 4, 2024

Related to #2161

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Sticker forwarding doesn't work and it needs more work to fix it
Since this is probably not very urgent I'm just disabling forwarding for sticker events

Motivation and context

We don't want broken functionality to be available

Screenshots / GIFs

image

Tests

  • Long press a sticker
  • Forward should not be there

Tested devices

  • Physical
  • Emulator
  • OS version(s):
    Android 13

Checklist

@surakin surakin requested a review from a team as a code owner January 4, 2024 12:12
@surakin surakin requested review from bmarty and removed request for a team January 4, 2024 12:12
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (3a8bc4c) 66.97% compared to head (5d93140) 66.97%.
Report is 5 commits behind head on develop.

Files Patch % Lines
...es/messages/impl/actionlist/ActionListPresenter.kt 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2162      +/-   ##
===========================================
- Coverage    66.97%   66.97%   -0.01%     
===========================================
  Files         1375     1375              
  Lines        34219    34221       +2     
  Branches      7544     7545       +1     
===========================================
+ Hits         22919    22920       +1     
  Misses        7663     7663              
- Partials      3637     3638       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for polishing the sticker support you added to the project!

@bmarty bmarty merged commit e752248 into element-hq:develop Jan 4, 2024
11 of 13 checks passed
@surakin surakin deleted the do-not-forward-stickers branch January 4, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants