Introduce AsyncAction with a Confirmation state and use it for logout action

[bmarty]

Type of change

• Feature
• Bugfix
• Technical
• Other :

Content

Add AsyncAction similar to Async but to be used for action triggered by the user.
It also contain an Confirming class, which can optionally by used.

Motivation and context

Attempt to fix #2165, by updating the state only once when a confirmation is needed from the user.

Screenshots / GIFs

Tests

• Step 1
• Step 2
• Step ...

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes have been tested on an Android device or Android emulator with API 23
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/xRUE2y

[codecov]

Codecov Report

Attention: 81 lines in your changes are missing coverage. Please review.

Comparison is base (b9a7b11) 67.03% compared to head (1fcb8fe) 67.01%.
Report is 18 commits behind head on develop.

Files	Patch %	Lines
...ment/android/libraries/architecture/AsyncAction.kt	67.44%	12 Missing and 2 partials ⚠️
...curebackup/impl/disable/SecureBackupDisableView.kt	9.09%	7 Missing and 3 partials ⚠️
...tures/lockscreen/impl/unlock/PinUnlockPresenter.kt	55.55%	2 Missing and 2 partials ⚠️
...atures/login/impl/changeserver/ChangeServerView.kt	0.00%	1 Missing and 3 partials ⚠️
...nfirmaccountprovider/ConfirmAccountProviderView.kt	20.00%	0 Missing and 4 partials ⚠️
...res/roomdetails/impl/blockuser/BlockUserSection.kt	20.00%	1 Missing and 3 partials ⚠️
...searchaccountprovider/SearchAccountProviderView.kt	25.00%	0 Missing and 3 partials ⚠️
...ures/logout/impl/direct/DefaultDirectLogoutView.kt	0.00%	2 Missing ⚠️
...roid/features/logout/impl/ui/LogoutActionDialog.kt	77.77%	1 Missing and 1 partial ⚠️
...mpl/notifications/NotificationSettingsPresenter.kt	66.66%	0 Missing and 2 partials ⚠️
... and 30 more

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2166      +/-   ##
===========================================
- Coverage    67.03%   67.01%   -0.02%     
===========================================
  Files         1375     1376       +1     
  Lines        34184    34177       -7     
  Branches      7448     7440       -8     
===========================================
- Hits         22914    22904      -10     
- Misses        7653     7660       +7     
+ Partials      3617     3613       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ElementBot]

	Warnings
⚠️	features/createroom/impl/src/main/kotlin/io/element/android/features/createroom/impl/configureroom/ConfigureRoomView.kt#L34 - Using a material import while also using the material3 library
⚠️	features/createroom/impl/src/main/kotlin/io/element/android/features/createroom/impl/configureroom/ConfigureRoomView.kt#L35 - Using a material import while also using the material3 library
⚠️	features/preferences/impl/src/main/kotlin/io/element/android/features/preferences/impl/user/editprofile/EditUserProfileView.kt#L30 - Using a material import while also using the material3 library
⚠️	features/preferences/impl/src/main/kotlin/io/element/android/features/preferences/impl/user/editprofile/EditUserProfileView.kt#L31 - Using a material import while also using the material3 library
⚠️	features/roomdetails/impl/src/main/kotlin/io/element/android/features/roomdetails/impl/edit/RoomDetailsEditView.kt#L34 - Using a material import while also using the material3 library
⚠️	features/roomdetails/impl/src/main/kotlin/io/element/android/features/roomdetails/impl/edit/RoomDetailsEditView.kt#L35 - Using a material import while also using the material3 library

Generated by 🚫 dangerJS against 1fcb8fe

[bmarty]

Interestingly, the flaky test this PR is attempting to fix is still failing. There is something else. Still digging, but maybe this PR can be merged (I am recording screenshot).

[jmartinesp]

The changes LGTM, it's a shame they don't fix the underlying issue. Will you handle that in another PR?

[bmarty]

@jmartinesp it should be OK with 1fcb8fe 🤞

[sonarqubecloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud