Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications: simplify the flow by removing persistence #2924

Merged
merged 16 commits into from
May 29, 2024

Fix some docs and do some cleanup

d7e38cf
Select commit
Loading
Failed to load commit list.
Merged

Notifications: simplify the flow by removing persistence #2924

Fix some docs and do some cleanup
d7e38cf
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 29, 2024 in 0s

75.35% (+0.10%) compared to 436a876

View this Pull Request on Codecov

75.35% (+0.10%) compared to 436a876

Details

Codecov Report

Attention: Patch coverage is 68.45426% with 100 lines in your changes are missing coverage. Please review.

Project coverage is 75.35%. Comparing base (436a876) to head (d7e38cf).
Report is 40 commits behind head on develop.

Files Patch % Lines
...push/impl/notifications/NotificationDataFactory.kt 70.00% 17 Missing and 13 partials ⚠️
...mpl/notifications/NotificationBroadcastReceiver.kt 0.00% 24 Missing ⚠️
...ations/factories/action/QuickReplyActionFactory.kt 0.00% 14 Missing ⚠️
.../notifications/DefaultNotificationDrawerManager.kt 69.44% 5 Missing and 6 partials ⚠️
...mpl/notifications/factories/NotificationCreator.kt 87.93% 2 Missing and 5 partials ⚠️
...es/push/impl/notifications/NotificationRenderer.kt 86.04% 2 Missing and 4 partials ⚠️
...raries/push/impl/push/OnNotifiableEventReceived.kt 0.00% 3 Missing ⚠️
...otifications/SystemNotificationsEnabledProvider.kt 0.00% 2 Missing ⚠️
...ent/android/features/call/CallForegroundService.kt 0.00% 1 Missing ⚠️
...ement/android/libraries/push/impl/di/PushModule.kt 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2924      +/-   ##
===========================================
+ Coverage    75.24%   75.35%   +0.10%     
===========================================
  Files         1550     1546       -4     
  Lines        36968    36790     -178     
  Branches      7156     7119      -37     
===========================================
- Hits         27817    27723      -94     
+ Misses        5414     5346      -68     
+ Partials      3737     3721      -16

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov