New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update grammar on Matrix Ids to be more spec compliant and render error instead of infinite loading in room member list screen #3206

Merged

bmarty merged 9 commits into develop from feature/bma/updateGrammar

Jul 17, 2024

Merged

Update grammar on Matrix Ids to be more spec compliant and render error instead of infinite loading in room member list screen #3206

Fix quality and test compilation.

Codecov / codecov/patch succeeded Jul 17, 2024 in 1s

88.88% of diff hit (target 76.14%)

View this Pull Request on Codecov

88.88% of diff hit (target 76.14%)

Annotations

Check warning on line 219 in features/roomdetails/impl/src/main/kotlin/io/element/android/features/roomdetails/impl/members/RoomMemberListView.kt

codecov / codecov/patch

features/roomdetails/impl/src/main/kotlin/io/element/android/features/roomdetails/impl/members/RoomMemberListView.kt#L219

Added line #L219 was not covered by tests

Check warning on line 233 in features/roomdetails/impl/src/main/kotlin/io/element/android/features/roomdetails/impl/members/RoomMemberListView.kt

codecov / codecov/patch

features/roomdetails/impl/src/main/kotlin/io/element/android/features/roomdetails/impl/members/RoomMemberListView.kt#L233

Added line #L233 was not covered by tests

Check warning on line 242 in features/roomdetails/impl/src/main/kotlin/io/element/android/features/roomdetails/impl/members/RoomMemberListView.kt

codecov / codecov/patch

features/roomdetails/impl/src/main/kotlin/io/element/android/features/roomdetails/impl/members/RoomMemberListView.kt#L242

Added line #L242 was not covered by tests

View more details on Codecov