Always display encryption badge

[bmarty]

Content

Ensure that the encryption badge are always displayed in the room detail screen, by removing the isPublic condition.

Motivation and context

Parity with iOS and advertise the encryption status of the room explicitely.

Screenshots / GIFs

Tests

• Open room detail screen of various room type and see that the encryption badge is always shown.

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes have been tested on an Android device or Android emulator with API 24
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request title will be used in the release note, it clearly define what will change for the user
• Pull request includes screenshots or videos if containing UI changes
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Kvt1VH

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.23%. Comparing base (73c66dd) to head (e214345).
Report is 3 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #4219      +/-   ##
===========================================
- Coverage    80.24%   80.23%   -0.01%     
===========================================
  Files         2042     2042              
  Lines        54079    54078       -1     
  Branches      6569     6568       -1     
===========================================
- Hits         43393    43391       -2     
  Misses        8414     8414              
- Partials      2272     2273       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.