Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme override #4226

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Theme override #4226

wants to merge 4 commits into from

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Jan 31, 2025

Content

Give ability to override theme color at build time.
Get color from ElementTheme instead of MaterialTheme when possible.

Motivation and context

Allow Element Enterprise customization.

Screenshots / GIFs

Tests

  • Should not impact the EXA application, only minor changes on the colors.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner January 31, 2025 17:49
@bmarty bmarty requested review from jmartinesp and removed request for a team January 31, 2025 17:49
@ElementBot
Copy link
Collaborator

Fails
🚫

Please add a PR- label to categorise the changelog entry.

Messages
📖 This pull request seems relatively large. Please consider splitting it into multiple smaller ones.

Generated by 🚫 dangerJS against d73cb32

Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/NM7ZAB

@bmarty bmarty added the PR-Misc For other changes label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants