Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable timeline in the middle test again. #1475

Merged
merged 2 commits into from
Aug 11, 2023

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Aug 10, 2023

After running happily for a few days, it has been failing for the last week, hiding signs of other tests failing.

Additionally fixes the room details avatar changing from an image to a button.

Run going on here: https://github.com/vector-im/element-x-ios/actions/runs/5823415696

@pixlwave pixlwave requested a review from a team as a code owner August 10, 2023 15:38
@pixlwave pixlwave requested review from alfogrillo and removed request for a team August 10, 2023 15:38
@github-actions
Copy link

github-actions bot commented Aug 10, 2023

Warnings
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 96442a1

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (975db4d) 53.22% compared to head (96442a1) 53.23%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1475   +/-   ##
========================================
  Coverage    53.22%   53.23%           
========================================
  Files          400      400           
  Lines        26744    26744           
  Branches     13384    13384           
========================================
+ Hits         14235    14236    +1     
+ Misses       12110    12108    -2     
- Partials       399      400    +1     
Flag Coverage Δ
unittests 23.15% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Aug 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@alfogrillo alfogrillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pixlwave pixlwave merged commit 27c3cdc into develop Aug 11, 2023
9 of 10 checks passed
@pixlwave pixlwave deleted the doug/disable-timeline-middle-test branch August 11, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants