Polls refinements

[alfogrillo]

This PR:

• Deletes the feature flags for polls
• Updates the "end poll" UI in the timeline
• Refines the focus logics in the "create poll" form
• Adds an alert when the user discards a "draft poll"

[github-actions]

	Warnings
⚠️	Please add a changelog.
⚠️	Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️	You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 2436c0f

[codecov]

Codecov Report

Patch coverage: 31.14% and project coverage change: +0.02% 🎉

Comparison is base (41662a5) 57.98% compared to head (2436c0f) 58.00%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1608      +/-   ##
===========================================
+ Coverage    57.98%   58.00%   +0.02%     
===========================================
  Files          410      410              
  Lines        27671    27696      +25     
  Branches     13728    13747      +19     
===========================================
+ Hits         16045    16066      +21     
- Misses       11182    11192      +10     
+ Partials       444      438       -6     

Flag	Coverage Δ
uitests	33.53% <31.14%> (+0.06%)	⬆️
unittests	22.77% <1.63%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
ElementX/Sources/Application/AppSettings.swift	96.49% <ø> (ø)
...urces/Screens/RoomScreen/RoomScreenViewModel.swift	53.56% <0.00%> (-0.08%)	⬇️
...ces/Screens/RoomScreen/View/TimelineItemMenu.swift	59.03% <0.00%> (-5.79%)	⬇️
...erOptionsScreen/DeveloperOptionsScreenModels.swift	0.00% <ø> (ø)
...perOptionsScreen/View/DeveloperOptionsScreen.swift	0.00% <ø> (ø)
ElementX/Sources/Services/Room/RoomProxy.swift	25.71% <0.00%> (ø)
...entX/Sources/Services/Room/RoomProxyProtocol.swift	68.00% <ø> (ø)
...meline/TimelineItems/RoomTimelineItemFactory.swift	22.47% <ø> (+0.13%)	⬆️
...s/CreatePollScreen/CreatePollScreenViewModel.swift	48.71% <11.11%> (-12.58%)	⬇️
...ns/ComposerToolbar/View/RoomAttachmentPicker.swift	87.05% <40.00%> (+4.30%)	⬆️
... and 3 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[stefanceriu]

lgtm 👍

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication