Avatar Bloom View in home screen navigation bar

[Velin92]

Simulator.Screen.Recording.-.iPhone.14.-.2023-09-07.at.16.24.07.mp4

[github-actions]

	Warnings
⚠️	Please add a changelog.
⚠️	Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️	You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 9df6213

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: -0.25% ⚠️

Comparison is base (1eac02f) 58.63% compared to head (913ef78) 58.38%.
Report is 1 commits behind head on develop.

❗ Current head 913ef78 differs from pull request most recent head 9df6213. Consider uploading reports for the commit 9df6213 to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1630      +/-   ##
===========================================
- Coverage    58.63%   58.38%   -0.25%     
===========================================
  Files          412      413       +1     
  Lines        28217    28329     +112     
  Branches     14058    14097      +39     
===========================================
- Hits         16545    16541       -4     
- Misses       11214    11331     +117     
+ Partials       458      457       -1     

Flag	Coverage Δ
unittests	22.69% <0.00%> (-0.09%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
ElementX/Sources/Other/ScrollViewAdapter.swift	34.92% <0.00%> (-4.37%)	⬇️
...tX/Sources/Screens/HomeScreen/View/BloomView.swift	0.00% <0.00%> (ø)
...X/Sources/Screens/HomeScreen/View/HomeScreen.swift	37.90% <0.00%> (-17.60%)	⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

[github-actions]

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/3iW5MH

[janogarcia]

Thanks for the demos and test build, Mauro! We're getting super close to the final implementation.

• Blending modes: We updated the values as follows. Light theme has a Hard Light bottom layer @ 20% opacity, and a top Color layer @ 80% opacity. Dark theme has a Exclusion bottom layer @ 50% opacity, and a top Color layer @ 20% opacity
• Soft edge mask: We settled 40px/pt for the linear gradient height.
• Collapsed navigation bar: The bloom shouldn't change its position, if possible, and just be cropped instead (e.g., behavior on Android).

[janogarcia]

Based on the latest screenshots that @Velin92 just shared over DM.

• When the Navigation Bar is not collapsed, the linear gradient mask for the "soft edge" effect seems to not be properly placed, there's a small visible gap.
• When the Navigation Bar is collapsed, we don't have to render the linear gradient mask for the "soft edge" effect.
• We should restore the hairline border on the Navigation Bar bottom.

[janogarcia]

A couple visual examples for

When the Navigation Bar is not collapsed, the linear gradient mask for the "soft edge" effect seems to not be properly placed, there's a small visible gap.

Light bloom edge

Dark bloom edge

[pixlwave]

👏👏👏

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication