Stop the sync service constantly attempting to restart on auth error. #1654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally removes a retain cycle that was preventing the client from being released.
Generated by 🚫 Danger Swift against c667017 |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #1654 +/- ##
===========================================
- Coverage 58.73% 58.52% -0.21%
===========================================
Files 412 413 +1
Lines 28223 28256 +33
Branches 14061 14078 +17
===========================================
- Hits 16577 16538 -39
- Misses 11187 11263 +76
+ Partials 459 455 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here. |
The SDK has changed a lot, we no longer need to stop and start the sync loop.
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally removes a retain cycle that was preventing the client from being released.
This really isn't the ultimate solution. The sync service should provide us with more context as to what error occurred, and more specifically, what conditions need to change before a restart is triggered (e.g. network conditions/some user input/none, its fatal)