Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Swift mocks by building local RustSDK #2290

Closed
wants to merge 2 commits into from

Conversation

nimau
Copy link
Contributor

@nimau nimau commented Dec 28, 2023

This PR:

  • updates the BuildSDK.swift tool to build Swift mocks when building locally the SDK
  • adds some unit tests for ClientProxy using generated mocks.

GH Issue: #2266

‼️ This PR depends on:

In the meantime, it can be tested locally by modifying matrix-rust-sdk/Cargo.toml as described here and by generating a local sdk using: swift run tools build-sdk

Copy link

sonarcloud bot commented Dec 28, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

4 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Warnings
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against a314f1d

Copy link

codecov bot commented Dec 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f844cd1) 72.39% compared to head (a314f1d) 72.38%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2290      +/-   ##
===========================================
- Coverage    72.39%   72.38%   -0.01%     
===========================================
  Files          512      512              
  Lines        35273    35273              
  Branches     16969    16969              
===========================================
- Hits         25536    25534       -2     
  Misses        9108     9108              
- Partials       629      631       +2     
Flag Coverage Δ
unittests 58.03% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefanceriu stefanceriu deleted the nicolas/clientproxy-unittests branch March 13, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants