Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix background update for sliding sync (find previous membership) (v2) #17632

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

erikjohnston
Copy link
Member

@erikjohnston erikjohnston commented Aug 29, 2024

This reverts commit ab414f2.

Introduced in #17512

@erikjohnston erikjohnston marked this pull request as ready for review August 29, 2024 16:20
@erikjohnston erikjohnston requested a review from a team as a code owner August 29, 2024 16:20
ORDER BY event_stream_ordering DESC
AND m.user_id = ?
AND e.stream_ordering < ?
ORDER BY e.stream_ordering DESC
Copy link
Contributor

@MadLittleMods MadLittleMods Aug 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For onlookers, see context in #17631 (comment)

@@ -1967,12 +1967,13 @@ def _find_previous_membership_txn(
txn.execute(
"""
SELECT event_id, membership
FROM room_memberships
FROM room_memberships AS m
INNER JOIN events AS e USING (room_id, event_id)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just double-checking that looking it up this way isn't slow vs just by (event_id)

The events table does have "events_room_stream" btree (room_id, stream_ordering) so I think this could work fast.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, empirically seems fast. Also helped by the fact these rooms should have very few events in them (generally just an invite then rejection)

@erikjohnston erikjohnston merged commit d844afd into develop Aug 29, 2024
39 checks passed
@erikjohnston erikjohnston deleted the erikj/ss_fix_bg_update branch August 29, 2024 18:16
@MadLittleMods MadLittleMods changed the title Fix background update for sliding sync (find previous membership) Fix background update for sliding sync (find previous membership) (v2) Aug 29, 2024
erikjohnston added a commit that referenced this pull request Aug 30, 2024
Follow-up to #17631 and
#17632 to fix-up
#17599

---------

Co-authored-by: Eric Eastwood <[email protected]>
erikjohnston added a commit that referenced this pull request Sep 5, 2024
erikjohnston added a commit that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants