Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try building multi-arch image #35

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Try building multi-arch image #35

merged 1 commit into from
Aug 29, 2024

Conversation

Arkaniad
Copy link
Contributor

If we're scheduling pods on arm64 which is now a possibility we'll get issues if this image is used as a sidecar and doesn't support arm64 if the pod it's scheduled for does. Use buildx to build both images.

Reference: https://blog.thesparktree.com/docker-multi-arch-github-actions

Copy link
Member

@benbz benbz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's give it a go

@benbz benbz merged commit 91a5bde into main Aug 29, 2024
1 check passed
@benbz benbz deleted the rdanzey/multiarch branch August 29, 2024 07:26
@benbz
Copy link
Member

benbz commented Aug 29, 2024

From https://github.com/element-hq/tailscale-k8s/actions/runs/10610614002/job/29408425087

crane manifest ghcr.io/element-hq/tailscale-k8s:main 
{
  "schemaVersion": 2,
  "mediaType": "application/vnd.oci.image.index.v1+json",
  "manifests": [
    {
      "mediaType": "application/vnd.oci.image.manifest.v1+json",
      "digest": "sha256:ed24f59f576e21d77222ee2d893bdd75287f1b8a4b07d1c5e7f05829b04d6fff",
      "size": 1054,
      "platform": {
        "architecture": "amd64",
        "os": "linux"
      }
    },
    {
      "mediaType": "application/vnd.oci.image.manifest.v1+json",
      "digest": "sha256:b1db3c0988cbd2bed574111c50f96e74c91503ddea00689ad8074e66c38f4d5b",
      "size": 566,
      "annotations": {
        "vnd.docker.reference.digest": "sha256:ed24f59f576e21d77222ee2d893bdd75287f1b8a4b07d1c5e7f05829b04d6fff",
        "vnd.docker.reference.type": "attestation-manifest"
      },
      "platform": {
        "architecture": "unknown",
        "os": "unknown"
      }
    }
  ]
}

So something is missing

@benbz benbz mentioned this pull request Aug 29, 2024
@benbz
Copy link
Member

benbz commented Aug 29, 2024

#36 has indeed fixed it. https://github.com/element-hq/tailscale-k8s/actions/runs/10610909314/job/29409303252 gives

crane manifest ghcr.io/element-hq/tailscale-k8s:main                       
{
  "schemaVersion": 2,
  "mediaType": "application/vnd.oci.image.index.v1+json",
  "manifests": [
    {
      "mediaType": "application/vnd.oci.image.manifest.v1+json",
      "digest": "sha256:3f629c5e07d694a10aab3152edc4dd8f3cc45902a4c50d03539a3e49c812b791",
      "size": 1054,
      "platform": {
        "architecture": "amd64",
        "os": "linux"
      }
    },
    {
      "mediaType": "application/vnd.oci.image.manifest.v1+json",
      "digest": "sha256:6b03354a95696ef39f6306c1811b04b3969e14a8bab7afece4b58f18136dcf0e",
      "size": 1054,
      "platform": {
        "architecture": "arm64",
        "os": "linux"
      }
    },
    {
      "mediaType": "application/vnd.oci.image.manifest.v1+json",
      "digest": "sha256:23269fdbe9afedbda9a1b327b5e9dc10cd7a78fb526e398e078c1d08c5fe7e8c",
      "size": 566,
      "annotations": {
        "vnd.docker.reference.digest": "sha256:3f629c5e07d694a10aab3152edc4dd8f3cc45902a4c50d03539a3e49c812b791",
        "vnd.docker.reference.type": "attestation-manifest"
      },
      "platform": {
        "architecture": "unknown",
        "os": "unknown"
      }
    },
    {
      "mediaType": "application/vnd.oci.image.manifest.v1+json",
      "digest": "sha256:ea8b959e67f00b024009b8be6b2e238903258899cbf7cc457e92dc7a14f92d41",
      "size": 566,
      "annotations": {
        "vnd.docker.reference.digest": "sha256:6b03354a95696ef39f6306c1811b04b3969e14a8bab7afece4b58f18136dcf0e",
        "vnd.docker.reference.type": "attestation-manifest"
      },
      "platform": {
        "architecture": "unknown",
        "os": "unknown"
      }
    }
  ]
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants