Fix meson warning for run_command #28
Conversation
| @@ -1,3 +1,3 @@ | |||
| project('appstream-data-pantheon') | |||
|
|
|||
| run_script = run_command('bash', meson.project_name() + '.sh') | |||
| run_script = run_command('bash', meson.project_name() + '.sh', check: false) | |||
There was a problem hiding this comment.
This script doesn't even exist, so it always fails. What's it supposed to do? What's the result of running Meson?
The script was removed in commit b616c8c for the record. Setting this to check: true would reveal that failure. ;)
There was a problem hiding this comment.
Haha, that's what I get by somewhat blindly scanning the repos for the run_command issue without fully understanding the repo first. 😅️
Looking at the commit you mentioned, it seems to me, as if the entire meson part is not needed anymore. Do you think it would be good to just remove the meson.build file?
There was a problem hiding this comment.
Probably?
Either that or reimplement it from scratch to install the relevant contents of pantheon-data/main/
Since I am already fixing the other repos with this issue, I thought I might do it here aswell.
TLDR: meson will change the default behaviour of
run_commandand displays that as a warning when building.See: mesonbuild/meson#9300