Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DesktopIntegration: Take stacking order into account #1884

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

DesktopIntegration: Take stacking order into account #1884

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
becf805
Sort windows by stacking
leolost2605 Apr 1, 2024
8dd08cc
Emit windows changed on stacking order change
leolost2605 Apr 1, 2024
f9acc77
Connect to display restacked instead of window raised
leolost2605 Apr 2, 2024
a476bc0
Emit windows_changed less, add comment
leolost2605 Apr 2, 2024
376e939
Merge branch 'master' into leolost/better-window-desktop-integration
danirabbit May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/DesktopIntegration.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public class Gala.DesktopIntegration : GLib.Object {
private unowned WindowManagerGala wm;
public uint version { get; default = 1; }
public signal void running_applications_changed ();
public signal void windows_changed ();
public signal void windows_changed (); // Only emitted if the number of windows changes, not if window properties change

public DesktopIntegration (WindowManagerGala wm) {
this.wm = wm;
Expand Down Expand Up @@ -59,7 +59,9 @@ public class Gala.DesktopIntegration : GLib.Object {
Window[] returned_windows = {};
var apps = Gala.AppSystem.get_default ().get_running_apps ();
foreach (unowned var app in apps) {
foreach (weak Meta.Window window in app.get_windows ()) {
var windows = wm.get_display ().sort_windows_by_stacking (app.get_windows ());
windows.reverse ();
foreach (weak Meta.Window window in windows) {
if (!is_eligible_window (window)) {
continue;
}
Expand Down