Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PanelClone: avoid using Timeout #2015

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

PanelClone: avoid using Timeout #2015

wants to merge 4 commits into from
+9 −6

Conversation

lenemter
Copy link
Member

No description provided.

@lenemter lenemter requested a review from a team August 10, 2024 14:26
leolost2605
leolost2605 reviewed Aug 12, 2024
View reviewed changes
Copy link
Member

@leolost2605 leolost2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks when disabling animation :(

leolost2605
leolost2605 reviewed Aug 12, 2024
View reviewed changes
Copy link
Member

@leolost2605 leolost2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want we can do it like this but wouldn't it maybe then just be easier to stay with the timeout?

@leolost2605 leolost2605 mentioned this pull request Oct 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leolost2605 leolost2605 leolost2605 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lenemter @leolost2605 @zeebok