Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stacking order after workspace switch #2081

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

leolost2605
Copy link
Member

@leolost2605 leolost2605 commented Oct 7, 2024

Starts addressing #2080

On main a 100% way to reproduce #2080 is having a maximized window so that the dock is hidden then trying to switch workspace so that a nudge plays and then trying to show the dock again. That is fixed by this PR. However there are more ways to reproduce #2080 so it's not entirely fixed.

#2080 will be fixed by #2094 however this can/should still be merged because the current behavior is just wrong

@leolost2605 leolost2605 requested a review from a team October 7, 2024 14:46
@leolost2605 leolost2605 mentioned this pull request Oct 7, 2024
@leolost2605
Copy link
Member Author

#2080 will be fixed by #2094 however this can/should still be merged because the current behavior is just wrong

Copy link
Member

@lenemter lenemter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, using prepend here breaks the stack order. Makes sense. Good job 👍

@lenemter lenemter enabled auto-merge (squash) October 17, 2024 16:36
@lenemter lenemter merged commit 58fc51c into main Oct 17, 2024
4 checks passed
@lenemter lenemter deleted the leolost/fix-stacking-order-on-nudge branch October 17, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants