Places: New design for folder icons #1311
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the new rounded folder style from the `system-file-manager` app icon for folders.
Add base `folder` icon at missing sizes Clean up borders of existing folders. Fix inconsistent aspect ratio between sizes.
danirabbit
reviewed
Sep 20, 2024
There was a problem hiding this comment.
These are so good! I especially like how much more open the folder-open is here. It looks like it has a lot more dimension to it. Great job
Proportions of everything looks good, and I noticed these fit the baseline better compared to other icons which is really great.
Honestly these are really lovely and they do look way more modern which is great. I just had a few little nitpicks, so I opened a branch I figured that would be easier than trying to type it out: newhoa#1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combines the newer design of the
system-file-managerapp icon with the color palette of the currentfoldericons. Also adjusts the aspect ratio to make it slightly wider, so it is not quite as square assystem-file-managerbut not quite as wide as the currentfoldericons.Closes #1305
This is what has been done as of the initial PR:
My initial thoughts/questions:
1) I am thinking the 16px folder should be slightly less rounded?(went ahead and adjusted this)2) I just added
folder-openat 48px, feedback for that one would be appreciated before I start on any other sizes.4) Is the aspect ratio of
folderokay? (personally, I am liking it a lot the more I use them so I hope that can stick).Any feedback would be appreciated!
Thanks!