Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rust mime #983

Closed
wants to merge 3 commits into from
Closed

Add Rust mime #983

wants to merge 3 commits into from

Conversation

apcamargo
Copy link

Closes #979

@lainsce
Copy link
Contributor

lainsce commented Jan 2, 2021

Those small sizes have the Rust logo a lot blurry, could you try to make it fit the pixel-grid?

@apcamargo
Copy link
Author

@lainsce, I tried to edit the logo to fit into the grid but I couldn't improve it that much. Rust logo is really complex.

Do you think we can proceed this PR with just the 48, 64, and 128 sizes? I've noticed that there are some other icons that are also not available at smaller sizes.

@lainsce
Copy link
Contributor

lainsce commented Jan 3, 2021

Maybe just 48 and 128 I guess, should cover the divisions pretty well (128 divides to 64 divides to 32 / 48 divides to 24), but try to make those two have the pixel-grid as much as possible.

A followup PR maybe from someone on the UX team may follow :P

@apcamargo
Copy link
Author

apcamargo commented Jan 13, 2021

Ok, so I deleted the smaller sizes and improved the fit to the grid a bit more. Rust logo is really complex, so it's not perfect. I did the same for the R logo (#987), although I maintained the 32 version there because I think it is looking good. Thanks again for the tips @lainsce!

In order to get a review from the UX team should I do something, or just wait? I know they have a lot on their plates right now, so I won't tag anyone them here.

There are some other mimetype icons that I'd like to add, but I prefer to get those right first to learn how to do this right.

@lainsce
Copy link
Contributor

lainsce commented Jan 13, 2021

Just keep doing PRs and the UX team will go one by one later.

@aerkiaga
Copy link

aerkiaga commented Nov 14, 2021

Rust's art license allows modifications to the artwork. I'd suggest making a second, simplified version of the logo that looks good at the smaller sizes. For example, you could remove the four small holes and make the outline a smooth circle with a radius that looks similar to the logo with teeth (radius with no teeth + tooth length/2). Then you could use one version for the larger sizes and another for the smaller ones.

@jeremypw
Copy link

@danrabbit Has this PR any chance? It has been outstanding a fair while.

@danirabbit
Copy link
Member

Hey thanks for your contribution! I just responded to the original issue report. Sorry I know it's not what you're hoping to hear!

Hey thanks for your suggestion. I'm really reluctant to add even more programming language file types. I think we are already supporting too many, especially because a lot of these logos don't look good at small sizes.

I think I would rather have some generic programming language icons that are like "compiled language", "interpreted language", "markup language" and then symlink to these more generic icons. It's unlikely you'll mix programming languages in the same project so it's probably just more useful to figure out like which is a class file and which is like styles or xml or whatever

Gonna close as "Design conflict" since I want to reduce the number of programming language icons rather than expand it

@danirabbit danirabbit closed this Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an icon for Rust (.rs) files
5 participants